Draft: Split logic of ExerciseResource into endpoints per exercise-type
#9570
Conversation
github-actions
bot
added
server
| */ | ||
| @GetMapping("exam/exercises/{exerciseId}") | ||
| @EnforceAtLeastEditor | ||
| public ResponseEntity<Exercise> getExamExercise(@PathVariable Long exerciseId) { |
There was a problem hiding this comment.
Dependency from exam->specific exercise should be fine for now, as one needs to know which exercises are created for an exam
|
|
||
| // Exam exercise | ||
| Exercise exercise = exerciseRepository.findByIdElseThrow(exerciseId); |
There was a problem hiding this comment.
We could reduce the repository call to just fetch the exercise type
| return authCheckService.isAllowedToSeeExercise(exercise, user); | ||
| } | ||
|
|
||
| public boolean isCorrectExerciseType(Exercise exercise, Class<? extends Exercise> expectedExerciseClass) { |
There was a problem hiding this comment.
This might not be needed here, we don't gain a lot from sharing this method.
| return expectedExerciseClass.isInstance(exercise); | ||
| } | ||
|
|
||
| public void setChannelName(Exercise exercise) { |
There was a problem hiding this comment.
We might want to improve the naming here. For me, it's something similar to hydrateWithXY or loadAndSetXY to express that we are loading something from the DB.
|
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
This is a draft, feel free to ignore :)